Handle return value of JS_ToFloat64 #891
Conversation
quickjs.c
Outdated
| if (JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit) < 0) { | ||
| // Ignore error since it sets d to NAN anyway. | ||
| } |
There was a problem hiding this comment.
Maybe better:
| if (JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit) < 0) { | |
| // Ignore error since it sets d to NAN anyway. | |
| } | |
| // Ignore error since it sets d to NAN anyway. | |
| // coverity[check_return] | |
| JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit); |
Clearer and, from what I remember from node's coverity scans, "using" the value like you do here doesn't work.
There was a problem hiding this comment.
If that works, great!
There was a problem hiding this comment.
@trufae how could be test this?
saghul
force-pushed
the
handle-result-conv
branch
from
228596f to
863a6bd
Compare
|
A quick github search suggests that is indeed the right way to silence it. Updated! |
|
Looks good to me |
|
In case an exception is thrown by |
We restore the exception right after the dance, so it will be discarded. |
Fixes: #890